Skip to content

Update README.md after commits bff756b and 7709f45 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2024
Merged

Update README.md after commits bff756b and 7709f45 #259

merged 2 commits into from
May 3, 2024

Conversation

@giovanniruzzi
Copy link
Contributor

What

Checklist

mcollina
mcollina approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@giovanniruzzi
Copy link
Contributor Author

giovanniruzzi commented Apr 30, 2024 •
edited
Loading

Hi @mcollina
I'm facing some troubles with the CI. The test step fails because of:

Run actions/setup-node@v4
Attempting to download 14...
Not found in manifest. Falling back to download directly from Node
Error: Unable to find Node version '14' for platform darwin and architecture arm64

Did i miss anything? Should I update any file?

@mcollina
Copy link
Member

mcollina commented May 3, 2024

No, there was an issue in our CI.

@gurgunday gurgunday merged commit 39378c8 into fastify:master May 3, 2024
Eomm
Eomm reviewed May 3, 2024
View reviewed changes
examples/discord.js
},
auth: oauthPlugin.DISCORD_CONFIGURATION
},
startRedirectPath: '/login/facebook',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

-startRedirectPath: '/login/facebook',
+startRedirectPath: '/login/discord',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eomm Eomm Eomm left review comments

@mcollina mcollina mcollina approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@giovanniruzzi @mcollina @Eomm @gurgunday