Skip to content

feature: multiple connections #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2017
Merged

feature: multiple connections #14

merged 1 commit into from
Nov 6, 2017

Conversation

@wedgwood
Copy link
Contributor

@wedgwood wedgwood commented Nov 6, 2017

As titled, I send this PR to make it support using multiple connections at same time.

mcollina
mcollina approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

allevo
allevo suggested changes Nov 6, 2017
View reviewed changes
Copy link
Member

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The simplest way to implement this is to allow to choose "mongo" key in configuration.

Like

fastify
    .decorate(options.name || 'mongo', mongo)
    .addHook('onClose', close)

@wedgwood
Copy link
Contributor Author

wedgwood commented Nov 6, 2017

@allevo I am just keep same as fastify/fastify-postgres#11.

delvedor
delvedor approved these changes Nov 6, 2017
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit d78279b into fastify:master Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

+1 more reviewer

@allevo allevo allevo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wedgwood @mcollina @allevo @delvedor