feat: allow overriding or modifying the queryString for websockets #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow overriding or modifying the queryString when proxying websockets. Fixes: fastify#348
ttshivers
force-pushed
the
ws-querystring
branch
from
450adf1 to
b3e12d8
Compare
mcollina
requested changes
Apr 20, 2024
Add type test for queryString
Added a test in a new commit. Is that what you were looking for? |
|
Could a release be made with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding or modifying the queryString when proxying websockets.
Fixes: #348
Checklist
npm run testandnpm run benchmarkand the Code of conduct