Skip to content

Conversation

wtchangdm
Copy link
Contributor

The route config link still points to document for fastify 2.1.x.

This MR modifies the link to 4.8.x (since there is no link for major version 4.x).

It's slightly better than just pointing to latest as this plugin might not be compatible with the future fastify version (e.g. v5) right away.

Checklist

The route config link still points to document for fastify 2.1.x.

This MR modifies the link to 4.8.x (since there is no link for major version `4.x`). It's slightly better than just pointing to `latest` as this plugin might not be compatible with the future fastify version (e.g. v5) right away.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs Fdawgs changed the title Point route config link to fastify version 4.8.x docs(readme): fix route config link Oct 13, 2022
@Fdawgs Fdawgs merged commit 72703f2 into fastify:master Oct 13, 2022
@wtchangdm wtchangdm deleted the patch-1 branch October 14, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants