-
-
Notifications
You must be signed in to change notification settings - Fork 25
test: prepare plugin for fastify 4.x #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hmmmm GitHub CI Windows runners failure 🤔 |
|
CI is failing :( |
Can you manually trigger a CI re-run please ? |
|
It seems that there is a flacky test when running in the Windows environment. I need to go, but I will try to look at this later today or tomorrow. |
|
OK it seems good now (I hope 😸), I ended up rewriting the tests (I swapped I have triggered a few CI run cycles and it seems to be OK so 🤞. |
jsumners
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
@darkgl0w the merge into master has some issue 😞
https://github.com/fastify/fastify-caching/actions/runs/1541922678 Could you take a look? |
|
@Eomm > It seems that the root cause of the test flackyness is still there in Windows environments. Edit: PR sent thanks to GitHub.dev vscode !_! |
Hello.
This PR aims to :
preParsinghooks withonRequesthooks inside tests (Alias preParsing to onRequest hook. Deprecate preParsing fastify#3503)http.getcalls withfastify.inject,async/await... )Checklist
npm run testandnpm run benchmarkand/or benchmarksare includedand the Code of conduct