Skip to content

Conversation

@tiswrt
Copy link
Contributor

@tiswrt tiswrt commented Feb 28, 2021

This PR was already made some time ago #34, but was rejected due to a missing test.

When using reply.etag() the etagOnSend hook uses the cache payload, instead of the response payload.

I have added a test that checks whether the correct payload is returned.

Checklist

@mcollina mcollina assigned jsumners and unassigned jsumners Feb 28, 2021
@mcollina mcollina requested a review from jsumners February 28, 2021 10:17
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the instructions in pinojs/pino-pretty#144 (comment) so what we can credit the original author's work.

@tiswrt
Copy link
Contributor Author

tiswrt commented Mar 1, 2021

I followed your instructions and created a new PR #49 . Closing this one

@tiswrt tiswrt closed this Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants