Skip to content

Update fastify to v3 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 16, 2020
Merged

Update fastify to v3 #33

merged 6 commits into from
Jun 16, 2020

Conversation

@frikille
Copy link
Contributor

@frikille frikille commented Apr 30, 2020

  • Updated fastify to v3
  • Replaced greenkeeper config with dependabot
  • Moved CI from Travis to Github actions

This PR unblocks fastify/fastify#2217

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

jsumners
jsumners reviewed Apr 30, 2020
View reviewed changes
jsumners
jsumners reviewed Apr 30, 2020
View reviewed changes
mcollina
mcollina approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomheymann thomheymann mentioned this pull request May 1, 2020
Closed
51 tasks
@mcollina
Copy link
Member

mcollina commented May 1, 2020

@frikille can you please update the dependencies as well?

mcollina
mcollina requested changes May 1, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

jsumners
jsumners approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcollina
mcollina approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 02b9561 into fastify:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@jsumners jsumners jsumners approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frikille @mcollina @jsumners