chore: named hook handlers #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eomm
approved these changes
Sep 22, 2024
|
i mean more like, what is the naming convention? i used caching as prefix fo the hook handlers and a name describing the functionality- |
jsumners
approved these changes
Sep 23, 2024
| } | ||
|
|
||
| instance.addHook('onRequest', (req, res, next) => { | ||
| instance.addHook('onRequest', function cachingSetCacheControlHeader (req, res, next) { |
There was a problem hiding this comment.
This is really the only change needed in this PR. The other names are fine; the fact that they are named is enough. And we don't need names in the tests. The names provide information when reviewing stack traces, stepping through with a debugger, and reviewing observability data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Eomm
is this the naming you suggest in your book?