fix(types): option privacy in Nodenext | Node16 #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is this fixing? |
I added the informations. |
|
Can you please add a test? We use tsd |
I cannot provide the test, but I can give a minimal reproduction. |
gurgunday
requested changes
Mar 4, 2024
There was a problem hiding this comment.
I'm not sure this change fixes the issue you're having
In fact, there seems to be no issue according to tests, why is this passing?
|
Do you review the Reproduction? I think I have revealed it: there is using |
gurgunday
approved these changes
Mar 4, 2024
|
Not sure how we could test this... but reproducing is possible |
|
any chance of getting this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate commit #116
When use with typescript in compilerOptions:
"module": "Node16"|"Nodenext", it will call thenamespace fastifyCaching, that causedand should use
I don`t know why those tests-suits fail.
Checklist
and the Code of conduct
Reproduction