Skip to content

Implement if/then/else #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2018
Merged

Implement if/then/else #91

merged 1 commit into from
May 3, 2018

Conversation

@allevo
Copy link
Member

@allevo allevo commented May 2, 2018

Implement #90

@mcollina
Copy link
Member

mcollina commented May 2, 2018

Does this affects benchmarks at all?

@allevo
Copy link
Member Author

allevo commented May 2, 2018

If you are not using if/then/else feature, no code changes are made.

If you are using if/then/else feature, we need to add a runtime check against ajv so the performance is affected.

mcollina
mcollina approved these changes May 2, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina requested a review from delvedor May 2, 2018 21:26
delvedor
delvedor approved these changes May 3, 2018
View reviewed changes
Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit e47da97 into master May 3, 2018
@delvedor
Copy link
Member

delvedor commented May 3, 2018

Doh! Again merged too quickly! :S
Can you also update the docs? Sorry!

@allevo
Copy link
Member Author

allevo commented May 3, 2018

Can you also update the docs? Sorry!

no problem: my fault.

@mcollina mcollina mentioned this pull request May 5, 2018
Closed
@cemremengu cemremengu deleted the feature/jsonschema-if branch December 7, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@delvedor delvedor delvedor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@allevo @mcollina @delvedor