Skip to content

Serializing const type with ' character #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Serializing const type with ' character #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
362bfec
Fixed case when serializing const type with value that contains ' cha…
seidelmartin Nov 2, 2023
8ee2f46
Extracted single quote as regex and used replace instead of replaceAll
seidelmartin Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const Serializer = require('./lib/serializer')
const Validator = require('./lib/validator')
const Location = require('./lib/location')

const SINGLE_TICK = /'/g

let largeArraySize = 2e4
let largeArrayMechanism = 'default'

Expand Down Expand Up @@ -834,7 +836,7 @@ function buildConstSerializer (location, input) {
`
}

code += `json += '${JSON.stringify(schema.const)}'`
code += `json += '${JSON.stringify(schema.const).replace(SINGLE_TICK, "\\'")}'`

if (hasNullType) {
code += `
Expand Down
20 changes: 20 additions & 0 deletions test/const.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,26 @@ test('schema with const string and no input', (t) => {
t.ok(validate(JSON.parse(output)), 'valid schema')
})

test('schema with const string that contains \'', (t) => {
t.plan(2)

const schema = {
type: 'object',
properties: {
foo: { const: "'bar'" }
}
}

const validate = validator(schema)
const stringify = build(schema)
const output = stringify({
foo: "'bar'"
})

t.equal(output, '{"foo":"\'bar\'"}')
t.ok(validate(JSON.parse(output)), 'valid schema')
})

test('schema with const number', (t) => {
t.plan(2)

Expand Down