Skip to content

Conversation

@Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jul 27, 2023

With this PR we first handle all the required fields. If the field is required, it will throw early.

Checklist

@Uzlopak Uzlopak requested review from Eomm and ivan-tymoshenko July 27, 2023 21:48
@Uzlopak Uzlopak added the benchmark Label to run benchmark against PR and main branch label Jul 27, 2023
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label Jul 27, 2023
@climba03003 climba03003 added the benchmark Label to run benchmark against PR and main branch label Jul 28, 2023
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label Jul 28, 2023
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak added the benchmark Label to run benchmark against PR and main branch label Jul 28, 2023
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label Jul 28, 2023
@Uzlopak Uzlopak added the benchmark Label to run benchmark against PR and main branch label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

PR:

short string............................................. x 10,843,585 ops/sec ±0.51% (190 runs sampled)
short string with double quote........................... x 6,827,709 ops/sec ±0.22% (192 runs sampled)
long string without double quotes........................ x 10,566 ops/sec ±0.12% (191 runs sampled)
long string.............................................. x 9,330 ops/sec ±0.20% (192 runs sampled)
number................................................... x 585,287,699 ops/sec ±0.10% (193 runs sampled)
integer.................................................. x 122,007,553 ops/sec ±0.25% (192 runs sampled)
formatted date-time...................................... x 1,740,787 ops/sec ±0.13% (192 runs sampled)
formatted date........................................... x 1,255,304 ops/sec ±0.16% (192 runs sampled)
formatted time........................................... x 1,248,958 ops/sec ±0.34% (192 runs sampled)
short array of numbers................................... x 42,675 ops/sec ±0.33% (187 runs sampled)
short array of integers.................................. x 36,165 ops/sec ±0.38% (189 runs sampled)
short array of short strings............................. x 10,418 ops/sec ±0.29% (190 runs sampled)
short array of long strings.............................. x 10,271 ops/sec ±0.30% (193 runs sampled)
short array of objects with properties of different types x 5,156 ops/sec ±0.28% (191 runs sampled)
object with number property.............................. x 581,552,903 ops/sec ±0.15% (192 runs sampled)
object with integer property............................. x 122,818,455 ops/sec ±0.23% (191 runs sampled)
object with short string property........................ x 10,620,828 ops/sec ±0.28% (192 runs sampled)
object with long string property......................... x 9,262 ops/sec ±0.57% (192 runs sampled)
object with properties of different types................ x 1,009,048 ops/sec ±0.37% (191 runs sampled)
simple object............................................ x 4,966,820 ops/sec ±0.18% (191 runs sampled)
simple object with required fields....................... x 5,053,644 ops/sec ±0.18% (193 runs sampled)
object with const string property........................ x 585,862,026 ops/sec ±0.11% (192 runs sampled)
object with const number property........................ x 586,073,449 ops/sec ±0.11% (193 runs sampled)
object with const bool property.......................... x 584,798,650 ops/sec ±0.20% (193 runs sampled)
object with const object property........................ x 585,619,360 ops/sec ±0.11% (193 runs sampled)
object with const null property.......................... x 583,746,972 ops/sec ±0.19% (193 runs sampled)

MASTER:

short string............................................. x 10,759,284 ops/sec ±0.43% (192 runs sampled)
short string with double quote........................... x 6,679,325 ops/sec ±0.85% (192 runs sampled)
long string without double quotes........................ x 10,565 ops/sec ±0.05% (193 runs sampled)
long string.............................................. x 9,258 ops/sec ±0.21% (192 runs sampled)
number................................................... x 583,089,285 ops/sec ±0.16% (192 runs sampled)
integer.................................................. x 121,839,291 ops/sec ±0.12% (193 runs sampled)
formatted date-time...................................... x 1,730,555 ops/sec ±0.13% (193 runs sampled)
formatted date........................................... x 1,244,143 ops/sec ±0.28% (192 runs sampled)
formatted time........................................... x 1,248,215 ops/sec ±0.16% (193 runs sampled)
short array of numbers................................... x 41,895 ops/sec ±0.36% (188 runs sampled)
short array of integers.................................. x 35,329 ops/sec ±0.43% (192 runs sampled)
short array of short strings............................. x 10,098 ops/sec ±0.43% (193 runs sampled)
short array of long strings.............................. x 10,222 ops/sec ±0.37% (192 runs sampled)
short array of objects with properties of different types x 5,099 ops/sec ±0.37% (193 runs sampled)
object with number property.............................. x 579,374,835 ops/sec ±0.18% (193 runs sampled)
object with integer property............................. x 122,303,887 ops/sec ±0.12% (193 runs sampled)
object with short string property........................ x 10,561,467 ops/sec ±0.26% (192 runs sampled)
object with long string property......................... x 9,260 ops/sec ±0.25% (192 runs sampled)
object with properties of different types................ x 996,865 ops/sec ±0.35% (190 runs sampled)
simple object............................................ x 5,888,535 ops/sec ±0.32% (193 runs sampled)
object with const string property........................ x 584,782,389 ops/sec ±0.24% (193 runs sampled)
object with const number property........................ x 585,838,154 ops/sec ±0.12% (193 runs sampled)
object with const bool property.......................... x 585,943,765 ops/sec ±0.10% (193 runs sampled)
object with const object property........................ x 585,944,818 ops/sec ±0.10% (193 runs sampled)
object with const null property.......................... x 585,974,105 ops/sec ±0.14% (193 runs sampled)

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label Aug 1, 2023
@Uzlopak Uzlopak added the benchmark Label to run benchmark against PR and main branch label Aug 1, 2023
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

PR:

short string............................................. x 11,210,966 ops/sec ±0.59% (186 runs sampled)
short string with double quote........................... x 7,159,879 ops/sec ±0.55% (188 runs sampled)
long string without double quotes........................ x 10,913 ops/sec ±0.38% (187 runs sampled)
long string.............................................. x 9,645 ops/sec ±0.45% (186 runs sampled)
number................................................... x 617,994,415 ops/sec ±0.43% (185 runs sampled)
integer.................................................. x 128,150,054 ops/sec ±0.42% (187 runs sampled)
formatted date-time...................................... x 1,707,482 ops/sec ±0.41% (188 runs sampled)
formatted date........................................... x 1,268,185 ops/sec ±0.40% (185 runs sampled)
formatted time........................................... x 1,255,744 ops/sec ±0.34% (187 runs sampled)
short array of numbers................................... x 43,769 ops/sec ±0.47% (186 runs sampled)
short array of integers.................................. x 37,491 ops/sec ±0.52% (188 runs sampled)
short array of short strings............................. x 10,864 ops/sec ±0.43% (186 runs sampled)
short array of long strings.............................. x 10,653 ops/sec ±0.49% (184 runs sampled)
short array of objects with properties of different types x 5,428 ops/sec ±0.49% (188 runs sampled)
object with number property.............................. x 606,177,461 ops/sec ±0.41% (186 runs sampled)
object with integer property............................. x 127,423,995 ops/sec ±0.40% (187 runs sampled)
object with short string property........................ x 11,264,025 ops/sec ±0.44% (188 runs sampled)
object with long string property......................... x 9,735 ops/sec ±0.44% (188 runs sampled)
object with properties of different types................ x 1,087,290 ops/sec ±0.47% (185 runs sampled)
simple object............................................ x 5,164,923 ops/sec ±0.39% (189 runs sampled)
simple object with required fields....................... x 5,170,423 ops/sec ±0.40% (187 runs sampled)
object with const string property........................ x 607,329,215 ops/sec ±0.53% (188 runs sampled)
object with const number property........................ x 611,405,460 ops/sec ±0.42% (189 runs sampled)
object with const bool property.......................... x 616,754,545 ops/sec ±0.42% (189 runs sampled)
object with const object property........................ x 606,043,779 ops/sec ±0.33% (186 runs sampled)
object with const null property.......................... x 613,302,310 ops/sec ±0.34% (187 runs sampled)

MASTER:

short string............................................. x 11,274,377 ops/sec ±0.55% (186 runs sampled)
short string with double quote........................... x 7,150,293 ops/sec ±0.40% (189 runs sampled)
long string without double quotes........................ x 10,912 ops/sec ±0.41% (185 runs sampled)
long string.............................................. x 9,578 ops/sec ±0.45% (187 runs sampled)
number................................................... x 613,094,444 ops/sec ±0.35% (189 runs sampled)
integer.................................................. x 127,675,789 ops/sec ±0.47% (188 runs sampled)
formatted date-time...................................... x 1,819,895 ops/sec ±0.46% (187 runs sampled)
formatted date........................................... x 1,311,805 ops/sec ±0.37% (187 runs sampled)
formatted time........................................... x 1,323,670 ops/sec ±0.45% (187 runs sampled)
short array of numbers................................... x 43,540 ops/sec ±0.42% (188 runs sampled)
short array of integers.................................. x 37,856 ops/sec ±0.52% (186 runs sampled)
short array of short strings............................. x 10,937 ops/sec ±0.47% (186 runs sampled)
short array of long strings.............................. x 10,733 ops/sec ±0.46% (186 runs sampled)
short array of objects with properties of different types x 5,304 ops/sec ±0.48% (187 runs sampled)
object with number property.............................. x 612,066,923 ops/sec ±0.36% (188 runs sampled)
object with integer property............................. x 126,160,491 ops/sec ±0.31% (189 runs sampled)
object with short string property........................ x 11,327,786 ops/sec ±0.47% (186 runs sampled)
object with long string property......................... x 9,701 ops/sec ±0.47% (186 runs sampled)
object with properties of different types................ x 1,042,202 ops/sec ±0.52% (186 runs sampled)
simple object............................................ x 5,228,171 ops/sec ±0.38% (186 runs sampled)
object with const string property........................ x 622,480,132 ops/sec ±0.41% (187 runs sampled)
object with const number property........................ x 612,984,394 ops/sec ±0.40% (186 runs sampled)
object with const bool property.......................... x 613,239,442 ops/sec ±0.40% (188 runs sampled)
object with const object property........................ x 620,907,746 ops/sec ±0.42% (187 runs sampled)
object with const null property.......................... x 614,287,198 ops/sec ±0.35% (188 runs sampled)

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label Aug 1, 2023
@Uzlopak Uzlopak merged commit 30a6f55 into master Aug 1, 2023
@simoneb simoneb deleted the process-required-early branch March 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants