Skip to content

Conversation

@MoLow
Copy link
Contributor

@MoLow MoLow commented Jul 23, 2023

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

@MoLow MoLow requested a review from mcollina July 24, 2023 06:53
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from ivan-tymoshenko July 24, 2023 08:20
@Uzlopak Uzlopak added the benchmark Label to run benchmark against PR and main branch label Jul 27, 2023
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label Jul 27, 2023
@mcollina
Copy link
Member

benchmarks looks ok at a first glance

@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 28, 2023

Anothet run with the new benchmarks.

Just for the fun...

@Uzlopak Uzlopak added the benchmark Label to run benchmark against PR and main branch label Jul 28, 2023
@github-actions
Copy link

PR:

short string............................................. x 18,841,683 ops/sec ±0.10% (594 runs sampled)
long string.............................................. x 11,201 ops/sec ±0.07% (593 runs sampled)
number................................................... x 706,361,870 ops/sec ±0.06% (594 runs sampled)
integer.................................................. x 147,401,245 ops/sec ±0.06% (594 runs sampled)
formatted date-time...................................... x 2,176,258 ops/sec ±0.08% (593 runs sampled)
formatted date........................................... x 1,560,121 ops/sec ±0.09% (593 runs sampled)
formatted time........................................... x 1,558,286 ops/sec ±0.10% (593 runs sampled)
short array of numbers................................... x 50,889 ops/sec ±0.13% (593 runs sampled)
short array of integers.................................. x 43,212 ops/sec ±0.11% (593 runs sampled)
short array of short strings............................. x 11,149 ops/sec ±0.14% (587 runs sampled)
short array of long strings.............................. x 11,171 ops/sec ±0.13% (588 runs sampled)
short array of objects with properties of different types x 6,010 ops/sec ±0.14% (591 runs sampled)
object with number property.............................. x 702,092,831 ops/sec ±0.08% (594 runs sampled)
object with integer property............................. x 148,046,386 ops/sec ±0.06% (594 runs sampled)
object with short string property........................ x 12,677,732 ops/sec ±0.10% (593 runs sampled)
object with long string property......................... x 11,144 ops/sec ±0.07% (593 runs sampled)
object with properties of different types................ x 1,162,775 ops/sec ±0.16% (592 runs sampled)
simple object............................................ x 5,255,033 ops/sec ±0.13% (593 runs sampled)
object with const string property........................ x 708,605,601 ops/sec ±0.05% (593 runs sampled)
object with const number property........................ x 708,395,426 ops/sec ±0.06% (593 runs sampled)
object with const bool property.......................... x 708,180,746 ops/sec ±0.07% (593 runs sampled)
object with const object property........................ x 708,123,042 ops/sec ±0.06% (594 runs sampled)
object with const null property.......................... x 707,838,773 ops/sec ±0.06% (594 runs sampled)

MASTER:

short string............................................. x 13,130,923 ops/sec ±0.35% (193 runs sampled)
short string with double quote........................... x 8,309,691 ops/sec ±0.21% (193 runs sampled)
long string without double quotes........................ x 12,651 ops/sec ±0.27% (193 runs sampled)
long string.............................................. x 11,134 ops/sec ±0.17% (194 runs sampled)
number................................................... x 706,453,821 ops/sec ±0.12% (194 runs sampled)
integer.................................................. x 147,654,121 ops/sec ±0.20% (194 runs sampled)
formatted date-time...................................... x 2,176,113 ops/sec ±0.12% (194 runs sampled)
formatted date........................................... x 1,560,534 ops/sec ±0.15% (194 runs sampled)
formatted time........................................... x 1,563,835 ops/sec ±0.17% (194 runs sampled)
short array of numbers................................... x 50,866 ops/sec ±0.28% (193 runs sampled)
short array of integers.................................. x 43,342 ops/sec ±0.33% (193 runs sampled)
short array of short strings............................. x 12,552 ops/sec ±0.31% (193 runs sampled)
short array of long strings.............................. x 12,325 ops/sec ±0.26% (192 runs sampled)
short array of objects with properties of different types x 6,112 ops/sec ±0.30% (193 runs sampled)
object with number property.............................. x 702,593,215 ops/sec ±0.10% (193 runs sampled)
object with integer property............................. x 148,259,143 ops/sec ±0.08% (194 runs sampled)
object with short string property........................ x 12,872,539 ops/sec ±0.25% (193 runs sampled)
object with long string property......................... x 11,094 ops/sec ±0.25% (194 runs sampled)
object with properties of different types................ x 1,194,368 ops/sec ±0.36% (191 runs sampled)
simple object............................................ x 6,001,296 ops/sec ±0.17% (191 runs sampled)
object with const string property........................ x 709,224,006 ops/sec ±0.09% (194 runs sampled)
object with const number property........................ x 708,417,235 ops/sec ±0.10% (194 runs sampled)
object with const bool property.......................... x 709,391,529 ops/sec ±0.10% (194 runs sampled)
object with const object property........................ x 708,727,969 ops/sec ±0.12% (194 runs sampled)
object with const null property.......................... x 709,619,839 ops/sec ±0.09% (194 runs sampled)

@github-actions github-actions bot removed the benchmark Label to run benchmark against PR and main branch label Jul 28, 2023
@Uzlopak Uzlopak merged commit 4b81cd6 into fastify:master Aug 1, 2023
@MoLow MoLow deleted the fix-anyOf-inside-allOf branch August 2, 2023 07:00
@MoLow
Copy link
Contributor Author

MoLow commented Aug 2, 2023

@mcollina @ivan-tymoshenko when is this expected to be released in Fastify itself?

@Uzlopak
Copy link
Contributor

Uzlopak commented Aug 2, 2023

Please give me a day or two. I have to make some perf checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typebox union serialization omits properties after upgrading from fastify v3

3 participants