chore: 582 - improving test coverage #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sasa Cvetkovic <[email protected]>
salesh
commented
Feb 25, 2023
| if (largeArrayMechanism !== 'default') { | ||
| if (largeArrayMechanism === 'json-stringify') { | ||
| functionCode += `if (arrayLength && arrayLength >= ${largeArraySize}) return JSON.stringify(obj)\n` | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
because validLargeArrayMechanisms -> this throw will never happen (we get an early throw if largeArrayMechanism is not default or json-stringify) so no need for it -> already covered by tests
salesh
commented
Feb 25, 2023
| return buildArrayTypeCondition(subType, accessor) | ||
| }) | ||
| condition = `(${conditions.join(' || ')})` | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
this case is not possible because validation of types schema is invalid: data/properties/ids/type must be equal to one of the allowed values -> already covered by tests
Contributor
There was a problem hiding this comment.
which line is already handling this already?
Contributor
Author
There was a problem hiding this comment.
Line 32 in c83cc32
switch
Contributor
Author
|
serializer.js: 98.85 -> 100% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#582
Improving test coverage part 1
Checklist
npm run testandnpm run benchmarkand the Code of conduct