use hasOwnProperty from Object.prototype #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-tymoshenko
approved these changes
Aug 23, 2022
Member
ivan-tymoshenko
left a comment
ivan-tymoshenko
left a comment
There was a problem hiding this comment.
LGTM, does it really make a difference?
Member
|
it's not about perf, it's about protecting from prototype injection |
Uzlopak
changed the title
This was referenced Aug 24, 2022
mcollina
pushed a commit
that referenced
this pull request
Aug 29, 2022
* Improved performance for const schema * Improve const object schema performance * Improve string and object performance * Restored example file * Changed findIndex with indexOf * Removed useless inference when schema is const * Review requests - Removed switchTypeSchema - Use of variable isRequired where defined - Rebase to PR #510 - Remove use of default value for const * Rebase to #510 (use hasOwnProperty from Object.prototype) * Use isRequired when available * Restored FJS format style * Restore FJS format style * Added support for nullable / type: [..., 'null']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not benchmark
Checklist
npm run testandnpm run benchmarkand the Code of conduct