fix benchmark-cmp-branch, remove chalk and inquirer #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove chalk and inquirer, use cli-select
RafaelGSS
approved these changes
Jun 25, 2022
Contributor
Author
|
Thanks. :) I realized that I forgot to remove chalk from ci.yml. Removed it there now too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmark-cmp-branch is broken, as inquirer 9.0.0 is now an ESM-Module, like latest chalk.
Instead of setting a lower version of inquirer and adding it into the blacklist of dependabot it like chalk I simply replaced inquirer with the less heavy cli-select and replaced chalk with basic ansi-codes for the color handling. I mean... after all it is only used for the benchmark.