fix: use ajv for schema ref resolving #454
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗BREAKING CHANGES
This PR uses ajv addSchema and getSchema methods for resolving json schema references. For this, we need to represent schema and external schemas in terms of json schema draft 7.
I think it's a good opportunity to fix some issues.
First of all when we pass external schemas as an object.
What do keys of the object mean in terms of json schema? Are they base URLs for these schemas? If so how should what should happen if we pass the key and $id?