refactor: use build value for additional and pattern properties #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-tymoshenko
deleted the
use-buildValue-for-additional-and-pattern-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object properties, additional object properties, and pattern object properties were processed by three different functions. I removed duplication. These three implementations had different ways to deal with array coercion. If it was an object property with array type it checked with Array.isArray function. If it was an additional or pattern property it didn't check but coerced to an array type in an unacceptable (IMHO) way.
Now it always checks the array typed value with Array.isArray function.
fast-json-stringify/test/additionalProperties.test.js
Line 161 in 1c120dd