Skip to content

Array ref #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2017
Merged

Array ref #19

merged 2 commits into from
Mar 11, 2017

Conversation

@delvedor
Copy link
Member

@delvedor delvedor commented Mar 11, 2017

  • Now arrays support $ref for items
...
arrayValue: {
  type: 'array',
  items: { $ref: '#/definitions/arrayKeys' }
}
...
  • Now we are keeping the full reference of the schema everywhere, because in case of deep objects refFinder was not working correctly.

mcollina
mcollina approved these changes Mar 11, 2017
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit 6eec05d into master Mar 11, 2017
@delvedor delvedor deleted the array-ref branch March 11, 2017 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@delvedor @mcollina