-
-
Notifications
You must be signed in to change notification settings - Fork 208
Fix/ref to #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/ref to #137
Conversation
|
Would this make it compatitble with fluent-schema? |
index.js
Outdated
| code += `['${walk[i]}']` | ||
| var wl = walk.length | ||
| if (wl === 1) { | ||
| return searchForId(schema, `#${ref[1]}`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put in a couple of comments explaining the if condition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, let me know if I should add more details
Yes, generally with this fix, the |
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, this PR fixes #136
I run the bench.js three times with Node 10.11.
I don't expect any improvement or defect on overall performance because these changes should be executed only when a
$ref = '#customId'is found.master:
this branch: