[BUG] Dedicated GPU detected as integrated.

General description of bug:

• What happened: dedicated AMD Radeon HD 7570M GPU is detected as integrated.
• What should happen: it should be detected as dedicated.
• Fastfetch version used: 2.16.0.
• Did it work in an older version: NO.
• Where did you get the binary: Scoop for Windows 11.
• Does this issue still occur in the latest dev build: Yes.

Often helpful information:

The content of the configuration file you use (if any): fastfetch c all.

Output of fastfetch -c ci.jsonc --format json:

{
  "type": "GPU",
  "result": [
    {
      "coreCount": null,
      "memory": {
        "dedicated": {
          "total": 1052770304,
          "used": null
        },
        "shared": {
          "total": 4026531840,
          "used": null
        }
      },
      "driver": "15.201.1301.0",
      "name": "AMD Radeon HD 7570M",
      "temperature": null,
      "type": "Integrated",
      "vendor": "AMD",
      "platformApi": "Direct3D 11.0",
      "frequency": null
    }
  ]
}

[FabioLolix]

I had this problem too on Arch Linux where the AMD Radeon Pro WX 4100 was indicated as integrated but testing again with the latest build from git (2.16.0.r19.g63cdc47d) is fixed

I will check again, and with Linux later.

Indeed, it doesn't happen on Linux.

[CarterLi]

Windows, Direct3D doesn't report the GPU type. I assume a GPU with VRAM smaller than 1 GiB is integrated.

Vulkan and OpenCL do. Test them with --gpu-detection-method vulkan and --gpu-detection-method opencl (requires the latest dev build)

GPU drivers (AMD and Intel, but not Nvidia) report it too. On Linux AMD and Intel GPU drivers are built into Linux kernel, so we can use it directly. On Windows it must be enabled with --gpu-driver-specific

[CarterLi]

I don't use AMD graphic cards and never tested fastfetch with the AMD GPU. Fastfetch uses AGS SDK. I don't know if it's bundled into AMD Windows driver package. If not, you must download it youself: https://github.com/GPUOpen-LibrariesAndSDKs/AGS_SDK/blob/master/ags_lib/lib/amd_ags_x64.dll

PCI detection still thinks the GPU is integrated with the latest build, OpenGL doesn't know the type, OpenCL knows it is dGPU, but the name appears as Turks instead of Radeon HD 7570M when I use it, and the GPU is too old to support vulkan.
Here's more info:

[
  {
    "type": "OS",
    "result": {
      "buildID": "",
      "codename": "",
      "id": "Windows 11",
      "idLike": "Windows",
      "name": "Windows",
      "prettyName": "Windows",
      "variant": "Pro",
      "variantID": "",
      "version": "11",
      "versionID": ""
    }
  },
  {
    "type": "GPU",
    "result": [
      {
        "coreCount": null,
        "memory": {
          "dedicated": {
            "total": 1052770304,
            "used": null
          },
          "shared": {
            "total": 4026531840,
            "used": null
          }
        },
        "driver": "15.201.1301.0",
        "name": "AMD Radeon HD 7570M",
        "temperature": null,
        "type": "Integrated",
        "vendor": "AMD",
        "platformApi": "Direct3D 11.0",
        "frequency": null,
        "deviceId": 40939
      }
    ]
  },
  {
    "type": "Vulkan",
    "error": "ffvkCreateInstance() failed: VK_ERROR_INCOMPATIBLE_DRIVER"
  },
  {
    "type": "OpenGL",
    "result": {
      "version": "4.5.13401 Compatibility Profile Context 15.201.1301.0",
      "renderer": "AMD Radeon HD 7570M",
      "vendor": "ATI Technologies Inc.",
      "slv": "4.40",
      "library": "WGL"
    }
  },
  {
    "type": "OpenCL",
    "result": {
      "version": "2.0 AMD-APP (1800.11)",
      "name": "AMD Accelerated Parallel Processing",
      "vendor": "Advanced Micro Devices, Inc.",
      "gpus": [
        {
          "type": "Discrete",
          "vendor": "AMD",
          "name": "Turks",
          "driver": "(VM)",
          "platformApi": "OpenCL 1.2 AMD-APP (1800.11)",
          "coreCount": 6,
          "frequency": 0.5,
          "memory": {
            "dedicated": {
              "total": 1073741824,
              "used": null
            },
            "shared": {
              "total": null,
              "used": null
            }
          },
          "deviceId": 3168419881552
        }
      ]
    }
  },
  {
    "type": "Version",
    "result": {
      "projectName": "fastfetch",
      "architecture": "x86_64",
      "version": "2.16.0",
      "versionTweak": "",
      "cmakeBuiltType": "RelWithDebInfo",
      "compileTime": "Jun 22 2024, 07:47:05",
      "compiler": "clang 18.1.6",
      "debugMode": false,
      "libc": "ucrt 14.0"
    }
  }
]

[CarterLi]

  {
    "type": "GPU",
    "result": [
      {
        "coreCount": null,
        "memory": {
          "dedicated": {
            "total": 1052770304,
            "used": null
          },
          "shared": {
            "total": 4026531840,
            "used": null
          }
        },
        "driver": "15.201.1301.0",
        "name": "AMD Radeon HD 7570M",
        "temperature": null,
        "type": "Integrated",
        "vendor": "AMD",
        "platformApi": "Direct3D 11.0",
        "frequency": null,
        "deviceId": 40939
      }
    ]
  }

This result suggests that --gpu-driver-specific didn't work (it should have coreCount and frequency detected). Did you put [amd_ags_x64.dll](https://github.com/GPUOpen-LibrariesAndSDKs/AGS_SDK/blob/master/ags_lib/lib/amd_ags_x64.dll) in the same folder of fastfetch?

Yes, I tried it and got same result, is anything more except for this file needed?

[CarterLi]

No. I don't know what happened. The code is very simple. It would be appriciated if you can debug it.

It looks like this check failed because revId was falsy (vendorId, deviceId and subSystemId were all truthy) and the AMD specific code never ran:

fastfetch/src/detection/gpu/gpu_windows.c

Line 147 in 88e075a

if (vendorId && deviceId && subSystemId && revId)

I'm not sure what this means, the check completes on my other, Intel integrated GPU.

Oh, wait, my GPU DeviceID is PCI\\VEN_1002&DEV_6841&SUBSYS_179D103C&REV_00, so revId is actually 0, is this normal?

There is one more problem; when I changed the check not to include revId, the liblary was loading, but apparently some race condition was occurring, since sometimes I got the right result (dedicated), sometimes I got the type as integrated, and sometimes fastfetch hanged an did not print the GPU module at all.
I fixed it by removing this statement:

fastfetch/src/detection/gpu/gpu_amd.c

Line 28 in 88e075a

ffagsDeInitialize(apiHandle);

Apparently it was called to early and sometimes interfered with processing of the GPU information.
I'm not sure though when to call it correctly (and if revId check can be safely skipped), so I won't send you a PR.

Also, I did need to add the amd_ags_x64.dll file to fastfetch directory for it to work, my Windows doesn't have it by default, I'm not sure if it is the same for newer cards.

[CarterLi]

Apparently it was called to early and sometimes interfered with processing of the GPU information.

Seems ffagsDeInitialize will free pointers allocated in gpuInfo. Just leak them.