Skip to content

Remove special syntax for super(X) = A + B in favor of macro(X) = A + JOIN + B #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+6 −6
Closed

Remove special syntax for super(X) = A + B in favor of macro(X) = A + JOIN + B #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions 3.12/interpreter_definition.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,6 @@ and a piece of C code describing its semantics::
"op" "(" NAME "," stack_effect ")" "{" C-code "}"
|
"macro" "(" NAME ")" "=" uop ("+" uop)* ";"
|
"super" "(" NAME ")" "=" NAME ("+" NAME)* ";"

stack_effect:
"(" [inputs] "--" [outputs] ")"
Expand Down Expand Up @@ -128,10 +126,12 @@ and a piece of C code describing its semantics::
The following definitions may occur:

* `inst`: A normal instruction, as previously defined by `TARGET(NAME)` in `ceval.c`.
* `op`: A part instruction from which macros can be constructed.
* `op`: A micro-instruction from which macros can be constructed.
* `macro`: A bytecode instruction constructed from ops and cache effects.
* `super`: A super-instruction, such as `LOAD_FAST__LOAD_FAST`, constructed from
normal or macro instructions.
This may be super-instruction, such as `LOAD_FAST__LOAD_FAST`;
in this case we write `macro(A__B) = A + JOIN + B;`, where `JOIN` is a special
micro-op designed for this use case (its "cache effect" is equivalent to bumping
the instruction counter).

`NAME` can be any ASCII identifier that is a C identifier and not a C or Python keyword.
`foo_1` is legal. `$` is not legal, nor is `struct` or `class`.
Expand Down Expand Up @@ -233,7 +233,7 @@ This would generate:
### Super-instruction definition

```C
super ( LOAD_FAST__LOAD_FAST ) = LOAD_FAST + LOAD_FAST ;
macro ( LOAD_FAST__LOAD_FAST ) = LOAD_FAST + JOIN + LOAD_FAST ;
```
This might get translated into the following:
```C
Expand Down