Skip to content

🚨 Fix signature of model_dump incompatible with supertype BaseModel #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

🚨 Fix signature of model_dump incompatible with supertype BaseModel #1591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20b0259
Fix `model_dump` signature
YuriiMotov Oct 7, 2025
da76d1a
Ignore `Cannot inherit from final class "FieldInfo" `
YuriiMotov Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sqlmodel/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def __dataclass_transform__(
return lambda a: a


class FieldInfo(PydanticFieldInfo):
class FieldInfo(PydanticFieldInfo): # type: ignore[misc]
def __init__(self, default: Any = Undefined, **kwargs: Any) -> None:
primary_key = kwargs.pop("primary_key", False)
nullable = kwargs.pop("nullable", Undefined)
Expand Down Expand Up @@ -868,6 +868,7 @@ def model_dump(
exclude_unset: bool = False,
exclude_defaults: bool = False,
exclude_none: bool = False,
exclude_computed_fields: bool = False,
round_trip: bool = False,
warnings: Union[bool, Literal["none", "warn", "error"]] = True,
fallback: Union[Callable[[Any], Any], None] = None,
Expand All @@ -893,6 +894,7 @@ def model_dump(
exclude_unset=exclude_unset,
exclude_defaults=exclude_defaults,
exclude_none=exclude_none,
exclude_computed_fields=exclude_computed_fields,
round_trip=round_trip,
warnings=warnings,
**extra_kwargs,
Expand Down
Loading