-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
📝 Add note about FIRST_SUPERUSER_PASSWORD
needing to be 40 characters or less
#1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tylermilner
wants to merge
2
commits into
fastapi:master
Choose a base branch
from
tylermilner:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−3
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -204,7 +204,7 @@ The input variables, with their default values (some auto generated) are: | |
- `stack_name`: (default: `"fastapi-project"`) The name of the stack used for Docker Compose labels and project name (no spaces, no periods) (in .env). | ||
- `secret_key`: (default: `"changethis"`) The secret key for the project, used for security, stored in .env, you can generate one with the method above. | ||
- `first_superuser`: (default: `"[email protected]"`) The email of the first superuser (in .env). | ||
- `first_superuser_password`: (default: `"changethis"`) The password of the first superuser (in .env). | ||
- `first_superuser_password`: (default: `"changethis"`) The password of the first superuser (in .env). Must be 40 characters or less. | ||
- `smtp_host`: (default: "") The SMTP server host to send emails, you can set it later in .env. | ||
- `smtp_user`: (default: "") The SMTP server user to send emails, you can set it later in .env. | ||
- `smtp_password`: (default: "") The SMTP server password to send emails, you can set it later in .env. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -23,7 +23,7 @@ first_superuser: | |||||
|
||||||
first_superuser_password: | ||||||
type: str | ||||||
help: The password of the first superuser (in .env) | ||||||
help: The password of the first superuser (in .env), must be 40 characters or less | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
default: changethis | ||||||
|
||||||
smtp_host: | ||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -132,7 +132,7 @@ You can set several variables, like: | |||||
* `BACKEND_CORS_ORIGINS`: A list of allowed CORS origins separated by commas. | ||||||
* `SECRET_KEY`: The secret key for the FastAPI project, used to sign tokens. | ||||||
* `FIRST_SUPERUSER`: The email of the first superuser, this superuser will be the one that can create new users. | ||||||
* `FIRST_SUPERUSER_PASSWORD`: The password of the first superuser. | ||||||
* `FIRST_SUPERUSER_PASSWORD`: The password of the first superuser. Must be 40 characters or less. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
* `SMTP_HOST`: The SMTP server host to send emails, this would come from your email provider (E.g. Mailgun, Sparkpost, Sendgrid, etc). | ||||||
* `SMTP_USER`: The SMTP server user to send emails. | ||||||
* `SMTP_PASSWORD`: The SMTP server password to send emails. | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
40
is default max size limit, but it can be configured.Also, there is a min length limit (
8
by default).