Skip to content

fix crash #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.20.3-1.20.4
Choose a base branch
from
Open

fix crash #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 36 additions & 27 deletions src/main/java/me/falu/twitchemotes/emote/texture/EmoteTextureHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,36 +37,45 @@ public float getWidth() {
}

public NativeImage getImage() {
if (this.textures.isEmpty() && !this.loading && !this.failed) {
new Thread(() -> {
List<EmoteBackedTexture> textures;
URL url;
try {
url = new URL(this.emote.url.replace("http:", "https:"));
} catch (MalformedURLException ignored) {
TwitchEmotes.LOGGER.error("Invalid URL for emote '" + this.emote.name + "'.");
TwitchEmotes.invalidateEmote(this.emote);
return;
}
try {
TextureReader textureReader = new TextureReader(url, this.emote.imageType);
textures = new ArrayList<>(textureReader.read());
} catch (IOException e) {
TwitchEmotes.LOGGER.error("Error while reading image for '" + this.emote.name + "'", e);
TwitchEmotes.invalidateEmote(this.emote);
this.failed = true;
try {
if (this.textures.isEmpty() && !this.loading && !this.failed) {
new Thread(() -> {
List<EmoteBackedTexture> textures;
URL url;
try {
url = new URL(this.emote.url.replace("http:", "https:"));
} catch (MalformedURLException ignored) {
TwitchEmotes.LOGGER.error("Invalid URL for emote '" + this.emote.name + "'.");
TwitchEmotes.invalidateEmote(this.emote);
return;
}
try {
TextureReader textureReader = new TextureReader(url, this.emote.imageType);
textures = new ArrayList<>(textureReader.read());
} catch (IOException e) {
TwitchEmotes.LOGGER.error("Error while reading image for '" + this.emote.name + "'", e);
TwitchEmotes.invalidateEmote(this.emote);
this.failed = true;
this.loading = false;
return null;
}
this.textures.addAll(textures);
this.loading = false;
return;
}
this.textures.addAll(textures);
this.loading = false;
}).start();
this.loading = true;
return null;
} else if (this.loading) {
}).start();
this.loading = true;
return null;
} else if (this.loading) {
return null;
}
return this.textures.get(this.currentFrame).getImage();
} catch (Exception e) {
TwitchEmotes.LOGGER.error("Error while reading image for '" + this.emote.name + "'", e);
TwitchEmotes.invalidateEmote(this.emote);
this.failed = true;
this.loading = false;
return null;
}
return this.textures.get(this.currentFrame).getImage();
return null;
}

public void postRender() {
Expand Down