Skip to content

improved docstring formatting and added safe return in factory method #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −9
Open

improved docstring formatting and added safe return in factory method #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9efe6c2
added default return value in get_localizer to prevent KeyError
ABHIRANJAN-KUMAR1 Nov 3, 2025
8c63fd0
cleaned up docstring formatting and removed unnecessary asterisks
ABHIRANJAN-KUMAR1 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions patterns/creational/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
"""
*What is this pattern about?
What is this pattern about?
It decouples the creation of a complex object and its representation,
so that the same process can be reused to build objects from the same
family.
This is useful when you must separate the specification of an object
from its actual representation (generally for abstraction).

*What does this example do?

What does this example do?
The first example achieves this by using an abstract base
class for a building, where the initializer (__init__ method) specifies the
steps needed, and the concrete subclasses implement these steps.
Expand All @@ -22,16 +21,15 @@ class for a building, where the initializer (__init__ method) specifies the
In general, in Python this won't be necessary, but a second example showing
this kind of arrangement is also included.

*Where is the pattern used practically?

*References:
https://sourcemaking.com/design_patterns/builder
Where is the pattern used practically?
See: https://sourcemaking.com/design_patterns/builder

*TL;DR
TL;DR
Decouples the creation of a complex object and its representation.
"""



# Abstract Building
class Building:
def __init__(self) -> None:
Expand Down
3 changes: 2 additions & 1 deletion patterns/creational/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ def get_localizer(language: str = "English") -> Localizer:
"Greek": GreekLocalizer,
}

return localizers[language]()
return localizers.get(language, EnglishLocalizer)()



def main():
Expand Down