Fix: avoid evaluating getters and prototype properties in dev-mode di… #35128
Conversation
|
Hi @Amitjoiya! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
| // Mainly for performance. We need to minimize to only relevant information. | ||
| let isDeeplyEqual = true; | ||
| let prevPropertiesChecked = 0; | ||
| for (const key in prev) { |
There was a problem hiding this comment.
Why change this loop if we're not accesing the getter?
| const nextKeys = Object.keys(next); | ||
| for (let i = 0; i < nextKeys.length; i++) { |
There was a problem hiding this comment.
Why change to Object.keys? This is a hot-path so it needs to be fine tuned for performance.
|
Thanks for the review! Only the exact requested corrections were made, and no other files or formatting were touched. Please let me know if anything else needs adjustment! |
2 participants
…ff (fixes #35126)
Summary
How did you test this change?