[DevTools] Measure when reconnecting Suspense #35098
Merged
+107
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Nov 10, 2025
| <Component key="inner-content"> | ||
| [suspense-root] rects={[{x:1,y:2,width:15,height:1}, {x:1,y:2,width:14,height:1}]} | ||
| <Suspense name="outer" rects={[{x:1,y:2,width:15,height:1}, {x:1,y:2,width:14,height:1}]}> | ||
| <Suspense name="inner" rects={[{x:1,y:2,width:14,height:1}]}> |
Collaborator
Author
There was a problem hiding this comment.
This measured a width of 13 without this change (see first commit) i.e. it was measuring without the resolved content.
eps1lon
force-pushed
the
sebbie/measure-reconnect
branch
from
7bde0dd to
92fc74f
Compare
eps1lon
force-pushed
the
sebbie/measure-reconnect
branch
from
92fc74f to
273e94d
Compare
sebmarkbage
approved these changes
Nov 10, 2025
This was referenced Nov 11, 2025
manNomi
pushed a commit
to manNomi/react
that referenced
this pull request
Nov 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reconnecting, we update the Suspense nodes while in a disconnected subtree where we don't measure. We need to measure explicitly when reconnecting an unsuspended Suspense node