[DevTools] Stop polyfilling Buffer
#34512
Merged
+90
−204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Sep 17, 2025
Comment on lines
+13
to
+17
| "@babel/parser": "^7.28.3", | ||
| "@babel/preset-env": "7.26.9", | ||
| "@babel/preset-flow": "^7.10.4", | ||
| "@babel/runtime": "^7.11.2", | ||
| "@babel/traverse": "^7.12.5", | ||
| "@babel/traverse": "^7.28.3", |
There was a problem hiding this comment.
|
Comparing: 6a4c8f5...552869b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
eps1lon
force-pushed
the
sebbie/09-17-_devtools_stop_polyfilling_buffer_
branch
3 times, most recently
from
2742e09 to
290438f
Compare
eps1lon
changed the title
Buffer
hoxyq
approved these changes
Sep 17, 2025
eps1lon
force-pushed
the
sebbie/09-17-_devtools_stop_polyfilling_buffer_
branch
from
290438f to
552869b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34514
Usage of
Bufferwas introduced in #21641Since then
atobis widely available in browsers (and workers). Node.js 16 also has it even though there's currently no Node.js target in DevTools (Flight renderer is only supported in the browser).The other usage of
Bufferwas in the transitive dependencyjsescwhich was caught by our e2e tests. A modern version ofjsescis now used which checks if Buffer exists first viatypeof Buffer.