[DevTools] Exclude roots from Suspense timeline that can't toggle Suspense #34239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/08-20-_devtools_exclude_roots_from_timeline_that_can_t_toggle_suspense
branch
from
d8fa742 to
9e1ff6a
Compare
hoxyq
reviewed
Aug 25, 2025
| @@ -2366,6 +2366,7 @@ export function attach( | |||
| !isProductionBuildOfRenderer && StrictModeBits !== 0 ? 1 : 0, | |||
| ); | |||
| pushOperation(hasOwnerMetadata ? 1 : 0); | |||
| pushOperation(supportsTogglingSuspense ? 1 : 0); | |||
There was a problem hiding this comment.
This is a breaking change in bridge logic between backend and frontend.
Could you please bump a version of bridge?
There was a problem hiding this comment.
5584209 (#34239) should do it? Maybe we just do a SemVer major for -inline for safety?
There was a problem hiding this comment.
This also affects React DevTools for React Native, because we ship backend and frontend separately.
Maybe we just do a SemVer major for -inline for safety?
Yeah, we will do it, but this won't help for cases where backend and frontend are used separately.
eps1lon
force-pushed
the
sebbie/08-20-_devtools_exclude_roots_from_timeline_that_can_t_toggle_suspense
branch
3 times, most recently
from
0d6dd75 to
5584209
Compare
hoxyq
approved these changes
Aug 26, 2025
There's more to consider with multi-root apps. This is specifically concerned with looking at production roots which won't have an toggleable Suspense at the moment.
eps1lon
force-pushed
the
sebbie/08-20-_devtools_exclude_roots_from_timeline_that_can_t_toggle_suspense
branch
from
5584209 to
4aaa3f9
Compare
|
Landed in #34251 (by accident) |
eps1lon
deleted the
sebbie/08-20-_devtools_exclude_roots_from_timeline_that_can_t_toggle_suspense
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #34233
There's more to consider with multi-root apps in the Suspense timeline.
This is specifically concerned with looking at production roots which won't have an toggleable Suspense at the moment.
This sends an additional value when adding a root over the bridge indicating whether this root supports toggling suspense. We didn't needed it previously since we just send that capability along with the inspected element. For the timeline we don't want to wait for the inspected element though.