-
Notifications
You must be signed in to change notification settings - Fork 49.9k
[react-dom] Include all Node.js APIs in Bun entrypoint for /server
#34193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react-dom] Include all Node.js APIs in Bun entrypoint for /server
#34193
Conversation
|
Hi @RiskyMH! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Comparing: 1d68bce...f4fe9ed Critical size changesIncludes critical production bundles, as well as any change greater than 2%: Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
react/scripts/error-codes/codes.json Lines 209 to 210 in 8a8e9a7
i wonder if these can be removed/edited now that bun actually supports node:stream well and thus the same apis as node (just with extra perf in some web api cases). |
…ct-dom # Conflicts: # packages/react-dom/npm/server.bun.js
These codes need to work for older versions of React. It seems like this message is specific to browser builds not Bun builds. |
|
Thanks @RiskyMH for creating this! |
bun's condition of react-dom/server to have latest normal node functions/server
eps1lon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…acebook#34193) DiffTrain build for [b4455a6](facebook@b4455a6)
…acebook#34193) DiffTrain build for [b4455a6](facebook@b4455a6)
Summary
fixes remix-run/react-router#12568, fixes #33612
The custom bun export condition seems to be missing some of the newer apis that normal node one has, so this PR adds the missing exports so that users of bun don't have errors.
How did you test this change?
used the built output and verified the functions are now present in the bun bundles