[Flight] Use cacheController instead of abortListeners for Streams #33633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
sebmarkbage
commented
Jun 24, 2025
| @@ -5257,7 +5254,7 @@ function enqueueFlush(request: Request): void { | |||
| } | |||
|
|
|||
| function callOnAllReadyIfReady(request: Request): void { | |||
| if (request.abortableTasks.size === 0 && request.abortListeners.size === 0) { | |||
There was a problem hiding this comment.
We used to need to check the listener count because it's what kept the stream alive while we were waiting on entries from the stream. Now I just let the task stay open and let the task be abortable which just logs an error for the stream.
unstubbable
approved these changes
Jun 25, 2025
sebmarkbage
force-pushed
the
abortsignalstreams
branch
from
6f2ea9f to
0a95b1b
Compare
This was referenced Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have
cacheSignal()we can just use that instead of theabortListenersconcept which was really just the same thing for cancelling the streams (ReadableStream, Blob, AsyncIterable).