Get Server Component Function Location for Parent Stacks using Child's Owner Stack #33629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
As a precaution I double check that it has the name in it.
sebmarkbage
force-pushed
the
parentstackfromowner
branch
from
8e7bdad to
58862fc
Compare
unstubbable
approved these changes
Jun 24, 2025
This was referenced Jun 25, 2025
hoxyq
added a commit
that referenced
this pull request
Jun 27, 2025
Full list of changes: * devtools: emit performance entries only when profiling ([hoxyq](https://github.com/hoxyq) in [#33652](#33652)) * Get Server Component Function Location for Parent Stacks using Child's Owner Stack ([sebmarkbage](https://github.com/sebmarkbage) in [#33629](#33629)) * Added minimum indent size to Component Tree ([jsdf](https://github.com/jsdf) in [#33517](#33517)) * [devtools-shell] layout options for testing ([jsdf](https://github.com/jsdf) in [#33516](#33516)) * Remove feature flag enableRenderableContext ([kassens](https://github.com/kassens) in [#33505](#33505)) * refactor[devtools]: update css for settings and support css variables in shadow dom scnenario ([hoxyq](https://github.com/hoxyq) in [#33487](#33487)) * [mcp] Add MCP tool to print out the component tree of the currently open React App ([jorge-cab](https://github.com/jorge-cab) in [#33305](#33305)) * [scripts] Switch back to flow parser for prettier ([rickhanlonii](https://github.com/rickhanlonii) in [#33414](#33414)) * upgrade json5 ([rickhanlonii](https://github.com/rickhanlonii) in [#33358](#33358)) * Get source location from structured callsites in prepareStackTrace ([sebmarkbage](https://github.com/sebmarkbage) in [#33143](#33143)) * Clean up enableSiblingPrerendering flag ([jackpope](https://github.com/jackpope) in [#32319](#32319))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using the same trick as #30798 but for runtime code too. It's essential zero cost.
This lets us include a source location for parent stacks of Server Components when it has an owned child's location. Either from JSX or I/O.
Ironically, a Component that throws an error will likely itself not get the stack because it won't have any JSX rendered yet.