Skip to content

[Fizz] Set keyPath for SuspenseList #33320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

sebmarkbage
Copy link
Collaborator

I missed setting the keyPath because the renderChildrenArray that this is forked from doesn't need to set a path but since this is rendered from the SuspenseList element it needs it.

@sebmarkbage sebmarkbage requested review from gnoff and eps1lon May 21, 2025 00:53
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 21, 2025
@react-sizebot
Copy link

Comparing: 9c7b10e...5d37a06

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 529.83 kB 529.83 kB = 93.52 kB 93.52 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.57 kB 651.57 kB = 114.78 kB 114.78 kB
facebook-www/ReactDOM-prod.classic.js = 675.81 kB 675.81 kB = 118.87 kB 118.87 kB
facebook-www/ReactDOM-prod.modern.js = 666.09 kB 666.09 kB = 117.26 kB 117.26 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server.production.js = 149.56 kB 149.13 kB = 25.75 kB 25.69 kB
oss-stable-semver/react-server/cjs/react-server.development.js = 189.56 kB 189.01 kB = 33.66 kB 33.60 kB
oss-stable/react-server/cjs/react-server.development.js = 189.56 kB 189.01 kB = 33.66 kB 33.60 kB
oss-stable-semver/react-server/cjs/react-server.production.js = 131.28 kB 130.89 kB = 23.01 kB 22.96 kB
oss-stable/react-server/cjs/react-server.production.js = 131.28 kB 130.89 kB = 23.01 kB 22.96 kB
oss-experimental/react-server/cjs/react-server.development.js = 209.59 kB 208.93 kB = 36.28 kB 36.20 kB

Generated by 🚫 dangerJS against 5d37a06

@sebmarkbage sebmarkbage merged commit 2388481 into facebook:main May 21, 2025
472 of 473 checks passed
github-actions bot pushed a commit that referenced this pull request May 21, 2025
I missed setting the `keyPath` because the `renderChildrenArray` that
this is forked from doesn't need to set a path but since this is
rendered from the `SuspenseList` element it needs it.

DiffTrain build for [2388481](2388481)
github-actions bot pushed a commit to code/lib-react that referenced this pull request May 21, 2025
I missed setting the `keyPath` because the `renderChildrenArray` that
this is forked from doesn't need to set a path but since this is
rendered from the `SuspenseList` element it needs it.

DiffTrain build for [2388481](facebook@2388481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants