[Fizz] Wrap revealCompletedBoundaries in a ViewTransitions aware version #33293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
…n needed For the external runtime we always include this wrapper. For others, we only include it if we have an ViewTransitions affecting. If we discover the ViewTransitions late, then we can upgrade an already emitted instruction.
sebmarkbage
force-pushed
the
fizzvtruntime
branch
from
7b9c112 to
5425556
Compare
…io that might need it We don't know if we'll actually outline a boundary to need this but just in case.
sebmarkbage
force-pushed
the
fizzvtruntime
branch
2 times, most recently
from
ffe59f1 to
a38be02
Compare
sebmarkbage
commented
May 16, 2025
| window['$RV'] = revealCompletedBoundariesWithViewTransitions.bind( | ||
| null, | ||
| revealCompletedBoundaries, | ||
| ); |
There was a problem hiding this comment.
Normally we’d want to make sure static functions like this gets inlined but since this function will be pass as first call into startViewTransition and reused in multiple places it needs to be a separate function anyway.
sebmarkbage
commented
May 16, 2025
| null, | ||
| // eslint-disable-next-line dot-notation | ||
| window['$RV'], | ||
| ); |
There was a problem hiding this comment.
We could optimize this by special casing when it goes together with the complete boundary instruction but it’s not really much difference atm so not worth it.
sebmarkbage
force-pushed
the
fizzvtruntime
branch
from
a38be02 to
fd248c9
Compare
gnoff
approved these changes
May 17, 2025
| @@ -896,6 +900,7 @@ export function getChildFormatContext( | |||
| } | |||
|
|
|||
| function getSuspenseViewTransition( | |||
| resumableState: ResumableState, | |||
There was a problem hiding this comment.
I originally thought I'd do it in both branches but then realized that I could do it only if we ever render the fallback.
github-actions bot
pushed a commit
that referenced
this pull request
May 17, 2025
…ion (#33293) When needed. For the external runtime we always include this wrapper. For others, we only include it if we have an ViewTransitions affecting. If we discover the ViewTransitions late, then we can upgrade an already emitted instruction. This doesn't yet do anything useful with it, that's coming in a follow up. This is just the mechanism for how it gets installed. DiffTrain build for [6060367](6060367)
This was referenced May 19, 2025
sebmarkbage
added a commit
that referenced
this pull request
May 22, 2025
Follow up to #33293. This solves a race condition when boundaries are added to the batch after the `startViewTransition` call. This doesn't matter yet but it will once we start assigning names before the `startViewTransition` call. A possible alternative solution might be to ensure the names are added synchronously in the event that adds to the batch. It's possible to keep adding to a batch until the snapshot has happened.
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
Follow up to #33293. This solves a race condition when boundaries are added to the batch after the `startViewTransition` call. This doesn't matter yet but it will once we start assigning names before the `startViewTransition` call. A possible alternative solution might be to ensure the names are added synchronously in the event that adds to the batch. It's possible to keep adding to a batch until the snapshot has happened. DiffTrain build for [91ac1fe](91ac1fe)
17 tasks
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When needed.
For the external runtime we always include this wrapper.
For others, we only include it if we have an ViewTransitions affecting. If we discover the ViewTransitions late, then we can upgrade an already emitted instruction.
This doesn't yet do anything useful with it, that's coming in a follow up. This is just the mechanism for how it gets installed.