Skip to content

[Fizz] Gate rel="expect" behind enableFizzBlockingRender #33183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

sebmarkbage
Copy link
Collaborator

Enabled in experimental channel.

We know this is critical semantics to enforce at the HTML level since if you don't then you can't add explicit boundaries after the fact. However, this might have to go in a major release to allow for upgrading.

@sebmarkbage sebmarkbage requested a review from eps1lon May 12, 2025 21:31
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label May 12, 2025
@react-sizebot
Copy link

react-sizebot commented May 12, 2025

Comparing: 5d04d73...9bb7288

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 528.09 kB 528.09 kB = 93.17 kB 93.17 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 646.40 kB 646.40 kB = 113.71 kB 113.71 kB
facebook-www/ReactDOM-prod.classic.js = 674.15 kB 674.15 kB = 118.41 kB 118.41 kB
facebook-www/ReactDOM-prod.modern.js = 664.43 kB 664.43 kB = 116.81 kB 116.81 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom-server.bun.development.js = 327.51 kB 326.52 kB = 63.72 kB 63.59 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js = 327.43 kB 326.44 kB = 63.69 kB 63.56 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js = 380.59 kB 379.43 kB = 68.43 kB 68.31 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js = 380.51 kB 379.36 kB = 68.38 kB 68.26 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js = 384.88 kB 383.69 kB = 69.21 kB 69.09 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js = 384.80 kB 383.61 kB = 69.16 kB 69.04 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js = 384.10 kB 382.91 kB = 69.07 kB 68.95 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js = 384.02 kB 382.83 kB = 69.02 kB 68.90 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js = 367.08 kB 365.74 kB = 66.66 kB 66.48 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js = 367.07 kB 365.74 kB = 66.66 kB 66.48 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js = 367.05 kB 365.72 kB = 66.63 kB 66.46 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js = 367.05 kB 365.72 kB = 66.63 kB 66.46 kB
oss-stable/react-dom/cjs/react-dom-server.edge.production.js = 240.22 kB 239.27 kB = 44.14 kB 44.00 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.production.js = 240.14 kB 239.19 kB = 44.12 kB 43.98 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.js = 235.01 kB 234.06 kB = 42.18 kB 42.06 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.js = 234.94 kB 233.99 kB = 42.16 kB 42.04 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js = 220.08 kB 219.19 kB = 40.52 kB 40.39 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js = 220.00 kB 219.11 kB = 40.49 kB 40.36 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.js = 236.83 kB 235.86 kB = 43.16 kB 43.01 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.js = 236.75 kB 235.78 kB = 43.14 kB 42.99 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.production.js = 219.69 kB 218.68 kB = 40.98 kB 40.83 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.production.js = 219.67 kB 218.66 kB = 40.95 kB 40.81 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.production.js = 215.18 kB 214.17 kB = 39.23 kB 39.08 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.production.js = 215.15 kB 214.14 kB = 39.21 kB 39.06 kB

Generated by 🚫 dangerJS against 9bb7288

@sebmarkbage sebmarkbage force-pushed the gateexpect branch 2 times, most recently from 34d54b3 to 102bec5 Compare May 12, 2025 22:21
@sebmarkbage sebmarkbage merged commit b94603b into facebook:main May 13, 2025
239 checks passed
github-actions bot pushed a commit that referenced this pull request May 13, 2025
Enabled in experimental channel.

We know this is critical semantics to enforce at the HTML level since if
you don't then you can't add explicit boundaries after the fact.
However, this might have to go in a major release to allow for
upgrading.

DiffTrain build for [b94603b](b94603b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants