Skip to content

[Fizz] Add "Queued" Status to SSR:ed Suspense Boundaries #33087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

sebmarkbage
Copy link
Collaborator

Stacked on #33076.

This fixes a bug where we used the "complete" status but the DOMContentLoaded event. This checks for not "loading" instead.

We also add a new status where the boundary has been marked as complete by the server but has not yet flushed either due to being throttled, suspended on CSS or animating.

@react-sizebot
Copy link

react-sizebot commented May 1, 2025

Comparing: ee7fee8...cfdce5a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.09% 527.81 kB 528.27 kB +0.07% 93.08 kB 93.14 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.07% 633.44 kB 633.90 kB +0.05% 111.27 kB 111.33 kB
facebook-www/ReactDOM-prod.classic.js +0.07% 671.22 kB 671.68 kB +0.05% 117.71 kB 117.77 kB
facebook-www/ReactDOM-prod.modern.js +0.07% 661.50 kB 661.96 kB +0.05% 116.15 kB 116.21 kB
oss-experimental/react-dom/unstable_server-external-runtime.js +2.48% 9.36 kB 9.60 kB +1.16% 2.51 kB 2.54 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/unstable_server-external-runtime.js +2.48% 9.36 kB 9.60 kB +1.16% 2.51 kB 2.54 kB

Generated by 🚫 dangerJS against cfdce5a

@sebmarkbage sebmarkbage merged commit 0ed6ceb into facebook:main May 1, 2025
13 of 15 checks passed
github-actions bot pushed a commit that referenced this pull request May 1, 2025
Stacked on #33076.

This fixes a bug where we used the "complete" status but the
DOMContentLoaded event. This checks for not "loading" instead.

We also add a new status where the boundary has been marked as complete
by the server but has not yet flushed either due to being throttled,
suspended on CSS or animating.

DiffTrain build for [0ed6ceb](0ed6ceb)
github-actions bot pushed a commit that referenced this pull request May 1, 2025
Stacked on #33076.

This fixes a bug where we used the "complete" status but the
DOMContentLoaded event. This checks for not "loading" instead.

We also add a new status where the boundary has been marked as complete
by the server but has not yet flushed either due to being throttled,
suspended on CSS or animating.

DiffTrain build for [0ed6ceb](0ed6ceb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants