Skip to content

[crud] Revert CRUD overload #32741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

[crud] Revert CRUD overload #32741

merged 1 commit into from
Mar 26, 2025

Conversation

poteto
Copy link
Member

@poteto poteto commented Mar 25, 2025

Cleans up this experiment. After some internal experimentation we are deprioritizing this project for now and may revisit it at a later point.

@react-sizebot
Copy link

react-sizebot commented Mar 25, 2025

Comparing: 8ac25e5...41524d4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.14 kB 514.93 kB = 91.73 kB 91.73 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 614.70 kB 614.48 kB = 108.76 kB 108.73 kB
facebook-www/ReactDOM-prod.classic.js = 650.77 kB 646.21 kB = 114.83 kB 114.22 kB
facebook-www/ReactDOM-prod.modern.js = 641.05 kB 636.49 kB = 113.26 kB 112.65 kB
facebook-www/React-profiling.classic.js = 21.46 kB 20.95 kB = 5.46 kB 5.34 kB
facebook-www/React-profiling.modern.js = 21.46 kB 20.95 kB = 5.46 kB 5.34 kB
facebook-www/React-prod.classic.js = 21.03 kB 20.51 kB = 5.38 kB 5.26 kB
facebook-www/React-prod.modern.js = 21.03 kB 20.51 kB = 5.38 kB 5.26 kB
facebook-react-native/react/cjs/React-profiling.js = 20.16 kB 19.60 kB = 5.21 kB 5.06 kB
facebook-react-native/react/cjs/React-prod.js = 19.72 kB 19.17 kB = 5.13 kB 4.98 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react/cjs/react.development.js = 46.75 kB 46.55 kB = 10.67 kB 10.62 kB
oss-stable/react/cjs/react.development.js = 45.06 kB 44.85 kB = 10.31 kB 10.25 kB
oss-stable-semver/react/cjs/react.development.js = 45.03 kB 44.83 kB = 10.28 kB 10.23 kB
facebook-www/ReactDOM-profiling.classic.js = 713.40 kB 708.87 kB = 123.91 kB 123.25 kB
facebook-www/ReactDOM-profiling.modern.js = 705.35 kB 700.83 kB = 122.56 kB 121.91 kB
facebook-www/ReactDOMTesting-prod.classic.js = 665.17 kB 660.61 kB = 118.46 kB 117.85 kB
facebook-www/ReactDOMTesting-prod.modern.js = 655.45 kB 650.89 kB = 116.86 kB 116.25 kB
facebook-www/ReactDOM-prod.classic.js = 650.77 kB 646.21 kB = 114.83 kB 114.22 kB
facebook-www/ReactDOM-prod.modern.js = 641.05 kB 636.49 kB = 113.26 kB 112.65 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js = 573.90 kB 569.38 kB = 101.17 kB 100.46 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js = 567.96 kB 563.44 kB = 100.01 kB 99.30 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js = 548.68 kB 544.12 kB = 97.43 kB 96.70 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js = 543.17 kB 538.61 kB = 96.35 kB 95.62 kB
test_utils/ReactAllWarnings.js = 64.27 kB 63.72 kB = 16.12 kB 15.96 kB
facebook-www/ReactReconciler-prod.classic.js = 497.72 kB 492.86 kB = 79.83 kB 79.17 kB
oss-experimental/react/cjs/react.production.js = 18.54 kB 18.36 kB = 4.80 kB 4.73 kB
facebook-www/ReactReconciler-prod.modern.js = 487.41 kB 482.55 kB = 78.21 kB 77.54 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,194.77 kB 1,182.74 kB = 199.69 kB 198.06 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,185.63 kB 1,173.60 kB = 197.91 kB 196.31 kB
facebook-www/ReactDOM-dev.classic.js = 1,178.23 kB 1,166.20 kB = 195.83 kB 194.25 kB
facebook-www/ReactDOM-dev.modern.js = 1,169.09 kB 1,157.06 kB = 194.12 kB 192.57 kB
oss-stable/react/cjs/react.production.js = 17.10 kB 16.92 kB = 4.48 kB 4.41 kB
oss-stable-semver/react/cjs/react.production.js = 17.08 kB 16.89 kB = 4.46 kB 4.38 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 355.64 kB 351.81 kB = 61.42 kB 60.80 kB
facebook-www/React-dev.classic.js = 55.56 kB 54.94 kB = 12.11 kB 11.98 kB
facebook-www/React-dev.modern.js = 55.56 kB 54.94 kB = 12.11 kB 11.98 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 333.51 kB 329.68 kB = 58.22 kB 57.62 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 409.40 kB 404.65 kB = 70.58 kB 69.80 kB
react-native/implementations/ReactFabric-profiling.fb.js = 405.76 kB 401.01 kB = 69.98 kB 69.18 kB
facebook-react-native/react/cjs/React-dev.js = 51.73 kB 51.12 kB = 11.49 kB 11.35 kB
facebook-www/ReactART-prod.classic.js = 383.56 kB 379.00 kB = 64.44 kB 63.81 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js = 1,010.55 kB 998.52 kB = 169.67 kB 168.19 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js = 994.23 kB 982.20 kB = 166.84 kB 165.36 kB
facebook-www/ReactART-prod.modern.js = 373.58 kB 369.01 kB = 62.81 kB 62.18 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 383.94 kB 379.15 kB = 66.72 kB 65.95 kB
react-native/implementations/ReactFabric-prod.fb.js = 380.30 kB 375.51 kB = 66.07 kB 65.26 kB
facebook-www/ReactReconciler-dev.classic.js = 817.01 kB 805.03 kB = 127.94 kB 126.53 kB
facebook-www/ReactReconciler-dev.modern.js = 807.80 kB 795.82 kB = 126.28 kB 124.88 kB
facebook-www/ReactART-dev.classic.js = 709.33 kB 697.36 kB = 111.46 kB 109.92 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 598.50 kB 588.40 kB = 96.50 kB 95.15 kB
facebook-www/ReactART-dev.modern.js = 699.83 kB 687.86 kB = 109.62 kB 108.09 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 675.40 kB 663.43 kB = 110.03 kB 108.42 kB
react-native/implementations/ReactFabric-dev.fb.js = 670.47 kB 658.50 kB = 109.14 kB 107.57 kB
facebook-www/React-profiling.classic.js = 21.46 kB 20.95 kB = 5.46 kB 5.34 kB
facebook-www/React-profiling.modern.js = 21.46 kB 20.95 kB = 5.46 kB 5.34 kB
facebook-www/React-prod.classic.js = 21.03 kB 20.51 kB = 5.38 kB 5.26 kB
facebook-www/React-prod.modern.js = 21.03 kB 20.51 kB = 5.38 kB 5.26 kB
facebook-react-native/react/cjs/React-profiling.js = 20.16 kB 19.60 kB = 5.21 kB 5.06 kB
facebook-react-native/react/cjs/React-prod.js = 19.72 kB 19.17 kB = 5.13 kB 4.98 kB

Generated by 🚫 dangerJS against 41524d4

Cleans up this experiment. After some internal experimentation we are deprioritizing this project for now and may revisit it at a later point.
@poteto poteto merged commit 313332d into main Mar 26, 2025
243 of 269 checks passed
@poteto poteto deleted the pr32741 branch March 26, 2025 16:05
github-actions bot pushed a commit that referenced this pull request Mar 26, 2025
Cleans up this experiment. After some internal experimentation we are
deprioritizing this project for now and may revisit it at a later point.

DiffTrain build for [313332d](313332d)
github-actions bot pushed a commit that referenced this pull request Mar 26, 2025
Cleans up this experiment. After some internal experimentation we are
deprioritizing this project for now and may revisit it at a later point.

DiffTrain build for [313332d](313332d)
github-actions bot pushed a commit to shlomiNugarker/react that referenced this pull request Mar 26, 2025
Cleans up this experiment. After some internal experimentation we are
deprioritizing this project for now and may revisit it at a later point.

DiffTrain build for [313332d](facebook@313332d)
github-actions bot pushed a commit to shlomiNugarker/react that referenced this pull request Mar 26, 2025
Cleans up this experiment. After some internal experimentation we are
deprioritizing this project for now and may revisit it at a later point.

DiffTrain build for [313332d](facebook@313332d)
eps1lon pushed a commit to vercel/next.js that referenced this pull request Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants