[compiler] Refactor validations to return Result and log where appropriate #32688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riate Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log. [ghstack-poisoned]
github-actions
bot
added
the
React Core Team
josephsavona
requested review from
mofeiZ and
poteto
and removed request for
mofeiZ
josephsavona
commented
Mar 20, 2025
Comment on lines
+267
to
+271
| env.logErrors(validateNoSetStateInPassiveEffects(hir)); | ||
| } | ||
|
|
||
| if (env.config.validateNoJSXInTryStatements) { | ||
| validateNoJSXInTryStatement(hir); | ||
| env.logErrors(validateNoJSXInTryStatement(hir)); |
There was a problem hiding this comment.
these two don't need to bailout, so now they just log
…here appropriate" Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log. [ghstack-poisoned]
…here appropriate" Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log. [ghstack-poisoned]
This was referenced Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.