Skip to content

[compiler] Refactor validations to return Result and log where appropriate #32688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

josephsavona
Copy link
Member

@josephsavona josephsavona commented Mar 20, 2025

Stack from ghstack (oldest at bottom):

Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.

…riate

Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.

[ghstack-poisoned]
josephsavona added a commit that referenced this pull request Mar 20, 2025
…riate

Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.

ghstack-source-id: bd59985
Pull Request resolved: #32688
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 20, 2025
@josephsavona josephsavona requested review from mofeiZ and poteto and removed request for mofeiZ March 20, 2025 17:16
Comment on lines +267 to +271
env.logErrors(validateNoSetStateInPassiveEffects(hir));
}

if (env.config.validateNoJSXInTryStatements) {
validateNoJSXInTryStatement(hir);
env.logErrors(validateNoJSXInTryStatement(hir));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these two don't need to bailout, so now they just log

Copy link
Contributor

@mofeiZ mofeiZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

…here appropriate"

Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.

[ghstack-poisoned]
josephsavona added a commit that referenced this pull request Mar 20, 2025
…riate

Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.

ghstack-source-id: f6aa4e7
Pull Request resolved: #32688
…here appropriate"

Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.

[ghstack-poisoned]
josephsavona added a commit that referenced this pull request Mar 20, 2025
…riate

Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.

ghstack-source-id: 418b5f5
Pull Request resolved: #32688
@josephsavona josephsavona merged commit 87ca93b into gh/josephsavona/72/base Mar 20, 2025
21 checks passed
josephsavona added a commit that referenced this pull request Mar 20, 2025
…riate

Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.

ghstack-source-id: 418b5f5
Pull Request resolved: #32688
@josephsavona josephsavona deleted the gh/josephsavona/72/head branch March 20, 2025 18:02
github-actions bot pushed a commit that referenced this pull request Mar 20, 2025
…riate

Updates ~all of our validations to return a Result, and then updates callers to either unwrap() if they should bailout or else just log.

ghstack-source-id: 418b5f5
Pull Request resolved: #32688

DiffTrain build for [e3c0642](e3c0642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants