Skip to content

[compiler][bugfix] Don't insert hook guards in retry pipeline #32665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2025
Merged

[compiler][bugfix] Don't insert hook guards in retry pipeline #32665

merged 1 commit into from
Mar 20, 2025

Conversation

mofeiZ
Copy link
Contributor

@mofeiZ mofeiZ commented Mar 19, 2025 •
edited
Loading

Fixing bug from #32164 -- prior to this PR, we inserted hook guards even for functions that bailed out of compilation.

@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 19, 2025
@mofeiZ
[compiler][bugfix] Don't insert hook guards in retry pipeline
8d2084b 
Fixing bug from #32164 -- prior to this PR, we inserted hook guards even for functions that bailed out of compilation.
@mofeiZ
Copy link
Contributor Author

mofeiZ commented Mar 20, 2025

Updated to use fn.env.isInferredMemoEnabled instead of fn.env.compilerMode === 'all_features'

@mofeiZ mofeiZ merged commit 0962f68 into main Mar 20, 2025
23 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 20, 2025
@mofeiZ
[compiler][bugfix] Don't insert hook guards in retry pipeline (#32665)
40af6fd 
Fixing bug from #32164 -- prior to
this PR, we inserted hook guards even for functions that bailed out of
compilation.

DiffTrain build for [0962f68](0962f68)
This was referenced Mar 21, 2025
Closed
Merged
@poteto poteto deleted the pr32665 branch March 26, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsavona josephsavona josephsavona approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mofeiZ @josephsavona @facebook-github-bot