[DevTools] Add fb local build command #32644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxyq
reviewed
Mar 17, 2025
Comment on lines
92
to
105
| {isInternalFacebookBuild && ( | ||
| <div className={styles.Setting}> | ||
| <label> | ||
| <input | ||
| type="checkbox" | ||
| checked={fbInternalFeaturesEnabled} | ||
| onChange={({currentTarget}) => | ||
| setFbInternalFeaturesEnabled(currentTarget.checked) | ||
| } | ||
| />{' '} | ||
| Enable fb internal features | ||
| </label> | ||
| </div> | ||
| )} |
There was a problem hiding this comment.
Instead of having a checkbox for everything, can we do this instead:
- Make this PR contain only change to extension build script. Looks good, I think we can merge it
- Based on
isInternalFacebookBuild, display a text inside the settings panel, saying like "This is an internal build of React DevTools for Meta".
Then, for all upcoming features we will only add a checkbox if this is an internal feature that can't be generalized or if this feature is optional / expensive to use.
hoxyq
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary 1. Having a development build for FB will be convenient for fb internal feature development 2. Add a new checkbox to toggle new internal features added to React Devtools. ## How did you test this change? 1. yarn test 2. set extra env variables in bash profile and build an internal version with the new script. 3. toggle on/off the new checkbox, the value is stored in local storage correctly. --------- Co-authored-by: Aohua Mu <[email protected]> DiffTrain build for [dc9b746](dc9b746)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?