[ci] Prepare publish workflow #32488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
|
Comparing: 227e841...6a8a199 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
poteto
force-pushed
the
pr32488
branch
2 times, most recently
from
dcd2788 to
519d2ee
Compare
poteto
commented
Feb 27, 2025
| for (let i = 0; i < entries.length; i++) { | ||
| const [bestGuessVersion, packages] = entries[i]; | ||
| const packageNames = packages.map(name => theme.package(name)).join(', '); | ||
| if (ci !== true) { |
Member
Author
There was a problem hiding this comment.
Only change here was this
Comment on lines
+19
to
+26
| if (ci === true) { | ||
| if (publishVersion != null) { | ||
| versionsMap.set(packageName, publishVersion); | ||
| } else { | ||
| const {major, minor, patch} = semver(version); | ||
|
|
||
| // Guess the next version by incrementing patch. | ||
| // The script will confirm this later. | ||
| // By default, new releases from mains should increment the minor version number, | ||
| // and patch releases should be done from branches. | ||
| if (branch === 'main') { | ||
| versionsMap.set(packageName, `${major}.${minor + 1}.0`); | ||
| console.error( | ||
| 'When running in CI mode, a publishVersion must be supplied' | ||
| ); | ||
| process.exit(1); |
Member
Author
There was a problem hiding this comment.
Only change here was this
poteto
force-pushed
the
pr32488
branch
2 times, most recently
from
c5ebe6b to
662ab4d
Compare
Fixes up a few things in the script and workflow to make it possible to run in CI without interactive prompts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up a few things in the script and workflow to make it possible to run in CI without interactive prompts.