Skip to content

[compiler] Stop reusing ScopeDep type in AnalyzeFunctions #30811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2024
Merged

[compiler] Stop reusing ScopeDep type in AnalyzeFunctions #30811

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf27fa1
[compiler] Stop reusing ScopeDep type in AnalyzeFunctions
josephsavona Aug 26, 2024
ca69ba4
Update on "[compiler] Stop reusing ScopeDep type in AnalyzeFunctions"
josephsavona Aug 27, 2024
475e710
Update on "[compiler] Stop reusing ScopeDep type in AnalyzeFunctions"
josephsavona Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions compiler/packages/babel-plugin-react-compiler/src/Inference/AnalyseFunctions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
IdentifierName,
LoweredFunction,
Place,
ReactiveScopeDependency,
isRefOrRefValue,
makeInstructionId,
} from '../HIR';
Expand All @@ -25,9 +24,14 @@ import {inferMutableContextVariables} from './InferMutableContextVariables';
import {inferMutableRanges} from './InferMutableRanges';
import inferReferenceEffects from './InferReferenceEffects';

type Dependency = {
identifier: Identifier;
path: Array<string>;
};

// Helper class to track indirections such as LoadLocal and PropertyLoad.
export class IdentifierState {
properties: Map<Identifier, ReactiveScopeDependency> = new Map();
properties: Map<Identifier, Dependency> = new Map();

resolve(identifier: Identifier): Identifier {
const resolved = this.properties.get(identifier);
Expand All @@ -39,7 +43,7 @@ export class IdentifierState {

declareProperty(lvalue: Place, object: Place, property: string): void {
const objectDependency = this.properties.get(object.identifier);
let nextDependency: ReactiveScopeDependency;
let nextDependency: Dependency;
if (objectDependency === undefined) {
nextDependency = {identifier: object.identifier, path: [property]};
} else {
Expand All @@ -52,9 +56,7 @@ export class IdentifierState {
}

declareTemporary(lvalue: Place, value: Place): void {
const resolved: ReactiveScopeDependency = this.properties.get(
value.identifier,
) ?? {
const resolved: Dependency = this.properties.get(value.identifier) ?? {
identifier: value.identifier,
path: [],
};
Expand Down