Skip to content

Conversation

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 11:22pm

@mofeiZ mofeiZ marked this pull request as ready for review August 6, 2024 03:15
Copy link
Member

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The dependency one is very clear, for the “value not memoized” case it might be nice to explain why “(because it may be mutated later)” but I like how you’re clarifying the two cases.

suggestions: null,
});
}
}
}
if (value.kind === 'FinishMemoize') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: else if

@mofeiZ mofeiZ merged commit 64701b6 into gh/mofeiZ/14/base Aug 8, 2024
19 checks passed
mofeiZ added a commit that referenced this pull request Aug 8, 2024
@mofeiZ mofeiZ deleted the gh/mofeiZ/14/head branch August 8, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants