Skip to content

[compiler] Refactor createTemporaryPlace #30585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024
+4 −11
Merged

[compiler] Refactor createTemporaryPlace #30585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/packages/babel-plugin-react-compiler/src/HIR/HIR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,7 +1205,7 @@ export type ValidIdentifierName = string & {
[opaqueValidIdentifierName]: 'ValidIdentifierName';
};

export function makeTemporary(
export function makeTemporaryIdentifier(
id: IdentifierId,
loc: SourceLocation,
): Identifier {
Expand Down
13 changes: 3 additions & 10 deletions compiler/packages/babel-plugin-react-compiler/src/HIR/HIRBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {
makeBlockId,
makeIdentifierName,
makeInstructionId,
makeTemporary,
makeTemporaryIdentifier,
makeType,
} from './HIR';
import {printInstruction} from './PrintHIR';
Expand Down Expand Up @@ -183,7 +183,7 @@ export default class HIRBuilder {

makeTemporary(loc: SourceLocation): Identifier {
const id = this.nextIdentifierId;
return makeTemporary(id, loc);
return makeTemporaryIdentifier(id, loc);
}

#resolveBabelBinding(
Expand Down Expand Up @@ -891,14 +891,7 @@ export function createTemporaryPlace(
): Place {
return {
kind: 'Identifier',
identifier: {
id: env.nextIdentifierId,
mutableRange: {start: makeInstructionId(0), end: makeInstructionId(0)},
name: null,
scope: null,
type: makeType(),
loc,
},
identifier: makeTemporaryIdentifier(env.nextIdentifierId, loc),
reactive: false,
effect: Effect.Unknown,
loc: GeneratedSource,
Expand Down