Skip to content

[compiler] Simplify FunctionExpression node #30544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

[compiler] Simplify FunctionExpression node #30544

merged 1 commit into from
Aug 2, 2024
+6 −6

Conversation

gsathya
Copy link
Contributor

@gsathya gsathya commented Jul 31, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

Rather than storing the entire babel node, store only the required
information which is the node type.

This will be useful for when we synthesize new functions that don't have
a corresponding babel node.

@gsathya
[compiler] Simplify FunctionExpression node
9f89dbf 
Rather than storing the entire babel node, store only the required
information which is the node type.

This will be useful for when we synthesize new functions that don't have
a corresponding babel node.

[ghstack-poisoned]
@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 1:40pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 31, 2024
This was referenced Jul 31, 2024
Merged
Merged
Merged
Merged
josephsavona
josephsavona approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yessss

@gsathya gsathya merged commit 9f89dbf into gh/gsathya/10/base Aug 2, 2024
gsathya added a commit that referenced this pull request Aug 2, 2024
@gsathya
[compiler] Simplify FunctionExpression node
a5a5816 
Rather than storing the entire babel node, store only the required
information which is the node type.

This will be useful for when we synthesize new functions that don't have
a corresponding babel node.

ghstack-source-id: 9098cbd
Pull Request resolved: #30544
@gsathya gsathya deleted the gh/gsathya/10/head branch August 2, 2024 17:14
@eps1lon eps1lon mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsavona josephsavona josephsavona approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsathya @josephsavona @facebook-github-bot