Skip to content

Conversation

jackpope
Copy link
Contributor

#30422 broke existing build shortcuts.

Revert the usage of names (_) and type args.

yarn build-for-devtools / yarn build-for-devtools-dev / yarn build-for-devtools-prod should all work again.

Moved the bundleType documentation into description so they can be fuzzy matched. But a build like yarn build --type FB_WWW_PROD still works when matched exactly.

There's probably a better way to document the positional names arg in the --help command, but didn't see it when browsing the yargs docs so let's just fix the existing builds for now.

Now:

% yarn build --help
yarn run v1.22.19
$ node ./scripts/rollup/build-all-release-channels.js --help
Options:
  --help                Show help                                                                                                                                             [boolean]
  --version             Show version number                                                                                                                                   [boolean]
  --releaseChannel, -r  Build the given release channel.                                                                                   [string] [choices: "experimental", "stable"]
  --index, -i           Worker id.                                                                                                                                             [number]
  --total, -t           Total number of workers.                                                                                                                               [number]
  --ci                  Run tests in CI                                                                                                                 [choices: "circleci", "github"]
  --type                Build the given bundle type. (NODE_ES2015,ESM_DEV,ESM_PROD,NODE_DEV,NODE_PROD,NODE_PROFILING,BUN_DEV,BUN_PROD,FB_WWW_DEV,FB_WWW_PROD,FB_WWW_PROFILING,RN_OSS_DE
                        V,RN_OSS_PROD,RN_OSS_PROFILING,RN_FB_DEV,RN_FB_PROD,RN_FB_PROFILING,BROWSER_SCRIPT)                                                                    [string]
  --pretty              Force pretty output.                                                                                                                                  [boolean]
  --sync-fbsource       Include to sync build to fbsource.                                                                                                                     [string]
  --sync-www            Include to sync build to www.                                                                                                                          [string]
  --unsafe-partial      Do not clean ./build first.     

Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 9:13pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 24, 2024
@jackpope jackpope requested a review from sebmarkbage July 24, 2024 21:10
@react-sizebot
Copy link

Comparing: a6b7e43...035900c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.44 kB 501.44 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.26 kB 506.26 kB = 90.68 kB 90.68 kB
facebook-www/ReactDOM-prod.classic.js = 599.78 kB 599.78 kB = 105.88 kB 105.88 kB
facebook-www/ReactDOM-prod.modern.js = 575.83 kB 575.83 kB = 102.15 kB 102.15 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against ab3a0f3

@jackpope jackpope merged commit e4b4aac into facebook:main Jul 25, 2024
@jackpope jackpope deleted the partial-build-2 branch July 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants