Match error behavior between Paper and Fabric for text strings #29875
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roper parent In Fabric, we switched from using an invariant for text strings to a soft error in facebook#22109. This change brings the same change to the Paper renderer.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Comparing: fb57fc5...921a136 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Fabric, we switched from using an invariant for text strings to a soft error in #22109.
This change brings the same change to the Paper renderer.
How did you test this change?
Applied these same changes locally while running React Native with the Paper renderer and confirmed that string children in unconfigured parent contexts no longer crash the app.