Skip to content

Conversation

@josephsavona
Copy link
Member

@josephsavona josephsavona commented May 17, 2024

Stack from ghstack (oldest at bottom):

Fixes a stale comment since this caused confusion in #29057 (comment)

@vercel
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 6:04pm

josephsavona added a commit that referenced this pull request May 17, 2024
ghstack-source-id: 8adb90b
Pull Request resolved: #29142
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 17, 2024
@react-sizebot
Copy link

react-sizebot commented May 17, 2024

Comparing: 3f1436c...0f02de2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 495.01 kB 495.01 kB = 88.68 kB 88.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 499.81 kB 499.81 kB = 89.36 kB 89.36 kB
facebook-www/ReactDOM-prod.classic.js = 592.16 kB 592.16 kB = 104.15 kB 104.15 kB
facebook-www/ReactDOM-prod.modern.js = 568.39 kB 568.39 kB = 100.55 kB 100.55 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 0f02de2

Fixes a stale comment since this caused confusion in #29057 (comment)

[ghstack-poisoned]
josephsavona added a commit that referenced this pull request May 17, 2024
ghstack-source-id: b6c98c7
Pull Request resolved: #29142
@josephsavona josephsavona merged commit 0f02de2 into gh/josephsavona/3/base May 17, 2024
josephsavona added a commit that referenced this pull request May 17, 2024
ghstack-source-id: b6c98c7
Pull Request resolved: #29142
@josephsavona josephsavona deleted the gh/josephsavona/3/head branch May 17, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants