Skip to content

Rename Controls to PipeableStream #24286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2022
+4 −4
Merged

Rename Controls to PipeableStream #24286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-dom/src/server/ReactDOMFizzServerNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ type Options = {|
onError?: (error: mixed) => void,
|};

type Controls = {|
type PipeableStream = {|
// Cancel any pending I/O and put anything remaining into
// client rendered mode.
abort(): void,
Expand Down Expand Up @@ -76,7 +76,7 @@ function createRequestImpl(children: ReactNodeList, options: void | Options) {
function renderToPipeableStream(
children: ReactNodeList,
options?: Options,
): Controls {
): PipeableStream {
const request = createRequestImpl(children, options);
let hasStartedFlowing = false;
startWork(request);
Expand Down
4 changes: 2 additions & 2 deletions packages/react-server-dom-webpack/src/ReactFlightDOMServerNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type Options = {
onError?: (error: mixed) => void,
};

type Controls = {|
type PipeableStream = {|
pipe<T: Writable>(destination: T): T,
|};

Expand All @@ -35,7 +35,7 @@ function renderToPipeableStream(
webpackMap: BundlerConfig,
options?: Options,
context?: Array<[string, ServerContextJSONValue]>,
): Controls {
): PipeableStream {
const request = createRequest(
model,
webpackMap,
Expand Down